Productive weekend

[afuna]

Productive weekend! Have 18 patches by me in the review queue, though some of them I did earlier last week. Focused on the blocking-launch bugs this weekend; picked up nine of the ones that were yet unclaimed (one of them I will need to submit a second patch for). A couple of other things caught my eye in the process, and I filed a bug for those, and submitted a patch for a couple.

Also asked a few questions to clarify some things that were confusing me, and they're all answered now, so I may be able to do a second run-through through the blocking-launch queue and pick up a couple more bugs (or someone else can pick them up, that works for me!)

Comments

[kareila]

Awesome! I feel like I have been slacking off lately, except for that one night I did like 5 patches in a row.

There are a couple of blocking-launch bugs I have an eye on, but they are big ones that I don't think will be done in an evening...

Maybe when Mark gets back I can convince him to let me in on the review/commit action too.

[synecdochic]

i luv you both liek whoa <333333

And while I'd totally be all for you having a commit bit, you can review stuff now! Glance them over, check that they're okay, apply them to your hack, do a basic functionality test, then review+ them. (And Fu, I'd be okay with you committing your own patches once someone else review+s them, at least while Mark's away; no need to let them sit.)

[afuna]

Okay, so my reaction to your comment is basically:

<3

Hooray! Hooray. (Hooray.)

[afuna]

You are so totally not slacking; you've been keeping my review queue full! :-)

(And I just saw you reviewed some of my patches \o/ No time to commit them now, but eeeeh :D :D :D :D :D)

PS. Just chiming in, but I would totally be happy to have more people reviewing/committing. And like D says, reviewing is open to everyone, though I think people tend to think that it's restricted like committing. I wonder how we can make it clear. Hm.

[kareila]

I dunno, maybe a post to dw_dev asking for more reviewers?

I mentioned the review queue to alierak and he might take a look at some things when he has the time.

I don't mind reviewing patches as long as I can figure out what they do and how to test them, but I still feel like a babydev in many respects. :)

[afuna]

zorkian started me out by asking me to comment on style. I didn't review+ or review- ing anything at first; didn't feel experienced enough to comment on anything but style. But gradually, I started noticing bugs, or tiny issues and bringing them up, at which point I started doing review- as necessary.

But I didn't review+ or commit+ for a while! I think what finally got me going was that Mark was busy with the payment system while ramping up to open beta (which meant I had to learn to pick up some of the slack so he wouldn't need to juggle so much), and now he's off enjoying his honeymoon (so there's no one else reasonably actively doing review/commit *g*), both of which were gigantic kicks in the butt to tackle reviewing/committing the harder bugs.

(Some stuff I'm still deferring to him, though, as you probably noticed!)

[pne]

What a pretty style you have!

[afuna]

I got it from an entry in dreamwidthlayouts *grin*

(Lots of other pretty styles there; this is one of my favorites (obviously!))