![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png){kind=small}
Sunday, February 13th, 2011
Perhaps the thing to do is to submit?
Right now I'm working on Issue 2614: hg grep returns binary content clobbering the terminal. My first attempt made it about three-fourths through, but I ran into issues integrating the new format with all the methods that expect the old format, at the end.
My biggest concern is that I removed the line numbers because they don't make sense for binary files :) Maybe I should ask first before review, but on the other hand maybe that's what review is for?
Eh, I'll probably just screw up my courage and hit the submit button some time tomorrow. Assuming I don't get hit by a sudden burst of inspiration that helps me solve all my niggling doubts about the code!
La la la la.
(Tomorrow I hit *my* review queue *g*)
Right now I'm working on Issue 2614: hg grep returns binary content clobbering the terminal. My first attempt made it about three-fourths through, but I ran into issues integrating the new format with all the methods that expect the old format, at the end.
My biggest concern is that I removed the line numbers because they don't make sense for binary files :) Maybe I should ask first before review, but on the other hand maybe that's what review is for?
Eh, I'll probably just screw up my courage and hit the submit button some time tomorrow. Assuming I don't get hit by a sudden burst of inspiration that helps me solve all my niggling doubts about the code!
La la la la.
(Tomorrow I hit *my* review queue *g*)